Fix empty image when navigating to new editor from an editor with image #5897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to be awkward, I tested out what happens if you hit the back button after going from an editor with an image, to a new editor. In this case the image is missing! |
|
So the path is:
|
|
Yes, sorry - exactly that 👍 |
kevinansfield
force-pushed
the
fix-cover-post
branch
2 times, most recently
from
bd773cc to
05bb2cd
Compare
|
This has been fixed up now. Would be great to re-visit the uploader at some point and re-implement with more control on the ember side. |
kevinansfield
force-pushed
the
fix-cover-post
branch
from
05bb2cd to
0e9f97b
Compare
closes TryGhost#5840 - calls `reset()` on the uploader when re-rendered with a blank image - calls `reset()` and `initWithImage()` on the uploader when re-rendered with an image and the uploader is still in the "blank" state
kevinansfield
force-pushed
the
fix-cover-post
branch
from
0e9f97b to
d49991f
Compare
ErisDS
added a commit
that referenced
this pull request
Oct 21, 2015
Fix empty image when navigating to new editor from an editor with image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5840
reset()function on the uploader if attrs change and the new image is emptyIssue was that when navigating from editing a post directly to writing a new post the controller and components are re-used with new values, because we are relying on a jQuery plugin we need to explicitly reset the plugin.